Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated Primer::CloseButton #1468

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 7, 2022

This removes the deprecated Primer::CloseButton component. It should be safe to ship when https://github.com/github/github/pull/241204 is merged

@jonrohan jonrohan requested review from a team and camertron October 7, 2022 23:02
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022

🦋 Changeset detected

Latest commit: 68abe7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Oct 7, 2022
@jonrohan jonrohan merged commit ae99c2e into main Oct 7, 2022
@jonrohan jonrohan deleted the remove_deprecated_close_button branch October 7, 2022 23:35
@primer-css primer-css mentioned this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants